[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] $EDITOR with spaces

From: Daniel Stenberg <daniel_at_haxx.se>
Date: 2002-04-18 10:54:55 CEST

On Wed, 17 Apr 2002, [UTF-8] Branko ─Œibej wrote:

> >I vote for requiring spaces to be escaped (possibly with backslashes like
> >"\ "), otherwise use them as separators.

> Hm, so you're gonna parse escapes in $EDITOR in the svn code?

Yes.

> What say we just forget it and call system() for this particular case, and
> let the shell handle that for us? For Windows, we just have to document
> that if you have spaces in the path, you must enclose the program name in
> double quotes, and cmd.exe (or command.com) will just magically DTRT.

The reasons for not using system() still remain the same ones as before I
take it.

One other benefit of doing the unescaping ourselves, would be that it would
not depend on your system or on your shell or whatever, but we could document
it and it would work the same on all platforms svn runs on...

Anyway, I'll post my suggested patch later today.

-- 
      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 18 10:55:58 2002

This is an archived mail posted to the Subversion Dev mailing list.