[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] checksums for text bases (early review opportunity)

From: <cmpilato_at_collab.net>
Date: 2002-04-12 19:49:01 CEST

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> This question is unrelated to the main point of your changes, Mike
> (which were great -- thanks for catching the stringbuf vs c-string
> thing). I just want to make sure I'm not missing something here:
>
> > svn_error_t *
> > svn_wc_process_committed (svn_stringbuf_t *path,
> > svn_boolean_t recurse,
> > @@ -213,9 +202,15 @@
> > {
> > svn_error_t *err;
> > apr_status_t apr_err;
> > - svn_stringbuf_t *log_parent, *logtag, *basename;
> > + svn_stringbuf_t *log_parent, *logtags, *basename;
> > apr_file_t *log_fp = NULL;
> > char *revstr = apr_psprintf (pool, "%ld", new_revnum);
> > + svn_stringbuf_t *checksum = NULL;
> > +
> > + /* Set PATH's working revision to NEW_REVNUM; if REV_DATE and
> > + REV_AUTHOR are both non-NULL, then set the 'committed-rev',
> > + 'committed-date', and 'last-author' entry values; and set the
> > + checksum if a file. */
> >
> > /* Write a log file in the adm dir of path. */
> >
> > @@ -228,7 +223,9 @@
> > if (err)
>
> Here, I had changed it to
>
> if (err && (err->apr_err == APR_ENOTDIR))
>
> in order to be make sure the error means what we think it means. Did
> you not preserve the change on purpose, because it was causing a
> problem, or did it just knocked out of your patch by accident? Your
> log message still mentions it, so I'm thinking the latter, but I want
> to make certain...

I made the change on purpose because it was too aggressive a fix.
That is, the error that we get back isn't always APR_ENOTDIR, yet is
still just as harmless an error, and therefore fine enough for
indicating that we're looking at a file instead of a dir.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 12 19:52:16 2002

This is an archived mail posted to the Subversion Dev mailing list.