[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] checksums for text bases (early review opportunity)

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-04-12 19:47:34 CEST

This question is unrelated to the main point of your changes, Mike
(which were great -- thanks for catching the stringbuf vs c-string
thing). I just want to make sure I'm not missing something here:

> svn_error_t *
> svn_wc_process_committed (svn_stringbuf_t *path,
> svn_boolean_t recurse,
> @@ -213,9 +202,15 @@
> {
> svn_error_t *err;
> apr_status_t apr_err;
> - svn_stringbuf_t *log_parent, *logtag, *basename;
> + svn_stringbuf_t *log_parent, *logtags, *basename;
> apr_file_t *log_fp = NULL;
> char *revstr = apr_psprintf (pool, "%ld", new_revnum);
> + svn_stringbuf_t *checksum = NULL;
> +
> + /* Set PATH's working revision to NEW_REVNUM; if REV_DATE and
> + REV_AUTHOR are both non-NULL, then set the 'committed-rev',
> + 'committed-date', and 'last-author' entry values; and set the
> + checksum if a file. */
>
> /* Write a log file in the adm dir of path. */
>
> @@ -228,7 +223,9 @@
> if (err)

Here, I had changed it to

     if (err && (err->apr_err == APR_ENOTDIR))

in order to be make sure the error means what we think it means. Did
you not preserve the change on purpose, because it was causing a
problem, or did it just knocked out of your patch by accident? Your
log message still mentions it, so I'm thinking the latter, but I want
to make certain...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 12 19:43:03 2002

This is an archived mail posted to the Subversion Dev mailing list.