[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] checksums for text bases (early review opportunity)

From: <cmpilato_at_collab.net>
Date: 2002-04-12 17:49:35 CEST

cmpilato@collab.net writes:

> Karl Fogel <kfogel@newton.ch.collab.net> writes:
>
> > This isn't working yet, but its general shape is pretty clear, so I'm
> > posting it now for people to review & comment early.
> >
> > Currently it can seg fault. The problem seems to occur in the xml
> > quoting code, because I mistakenly thought that APR's Md5 digests were
> > the long format (sixteen 7-bit chars or whatever it is). Apparently
> > they're not, and I need to learn how to convert to a friendlier format
> > for storage in the .svn/entries file anyway (independent of xml
> > escaping problem). Does this require apr_xlate.h, or is there some
> > easier way?
>
> Here, try this on for size (there were a number of boo-boos in your
> code that caused segfaults, it was only a matter of which was the
> first you hit while running the code :-) and I've changed the spec a
> bit to claim that the 'checksum' member of svn_wc_entry_t is actually
> a base64-encoded version of the MD5 checksum. Of course, I did the
> encoding as well.

Few more notes:

  - base64 should be safe for all of our DAV communications, too,
    since they generally use XML report/reponse mechanisms! while
    base64 itself is limited to 76 characters per line, that's more
    than enough to hold a 16-byte MD5 checksum without spanning lines.

  - note that I stripped the final "\n" from the base64-encoded
    checksum.

  - my version passes make check, and adds cool stuff like this the
    following to the entries files:
       checksum="xHh84q5soyVZTeN4dhRgdA=="

  - might need to rename the entries files' attribute `checksum' to
    `checksum-base64'.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 12 17:52:13 2002

This is an archived mail posted to the Subversion Dev mailing list.