[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1649 - trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-04-08 17:39:40 CEST

cmpilato@collab.net writes:
> Re 1: The bug this patch sought to fix was noticed only because
> everal people did NOT have $EDITOR (or $SVN_EDITOR or $VISUAL) set in
> their environments. I assume that if this condition was so horrible
> for them in their day-to-day use of Unix, they would have set the
> $EDITOR variables in their login/profile scripts. As for the config
> option, that's been discussed but I seem to remember some folks
> (gstein, kfogel?) thinking it unnecessary. I might be remembering
> wrongly, though.

A config option to set EDITOR would be useful, and easy to implement
now. People who want to use $EDITOR (like CVS) need do nothing with
their configs. People who want to specify a particular editor, or at
any rate want to ignore $EDITOR, can use the config option to set an
editor (or set to no editor).

I'm planning to do this, using a file `.subversion/options' for
generic config stuff like this.

> > 3) What BenC said about people expecting an editor to pop up even without
> > $EDITOR set.
>
> The first time that folks get the error about not finding an editor in
> the environment, they will remedy that situation by setting an
> environment variable, or by following the advice to use -F or -m.
> Sorry, I'm not seeing the big issue here.

Agree with CMike.

Having watched many new CVS users reel back from their screens in
shock when "cvs ci" suddenly threw vi in their faces, I feel it's safe
to say that popping up an editor is pretty weird behavior to those who
don't know it's coming. :-)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 8 17:34:33 2002

This is an archived mail posted to the Subversion Dev mailing list.