[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1649 - trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

From: <cmpilato_at_collab.net>
Date: 2002-04-07 19:59:22 CEST

Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:

> Some points about this change.
>
> 1) Unsetting $EDITOR isn't really all that feasible, since a lot of other
> programs use it. Why not have an option in the config file for it?
>
> 2) I thought we weren't going to have svn try to force log messages,
> since its not feasible anyways.

Actually, these two points have nothing to do with this change at
all. :-)

Re 1: The bug this patch sought to fix was noticed only because
everal people did NOT have $EDITOR (or $SVN_EDITOR or $VISUAL) set in
their environments. I assume that if this condition was so horrible
for them in their day-to-day use of Unix, they would have set the
$EDITOR variables in their login/profile scripts. As for the config
option, that's been discussed but I seem to remember some folks
(gstein, kfogel?) thinking it unnecessary. I might be remembering
wrongly, though.

Re 2: The $EDITOR code, since its addition several months ago, has
been somewhat enforcing log messages, even if they are empty strings.
This patch doesn't change that.

> 3) What BenC said about people expecting an editor to pop up even without
> $EDITOR set.

The first time that folks get the error about not finding an editor in
the environment, they will remedy that situation by setting an
environment variable, or by following the advice to use -F or -m.
Sorry, I'm not seeing the big issue here.

> 4) Will this fix other operations that commit, svn cp, svn mkdir, etc?

Fix? As far as I know, the only commit-y operation that was broken in
this case was commit. The others, IIRC, SVN_ERR () out when no
$EDITOR is found. Commit was not capturing, and therefore not
propagating, the error, so a silent NOOP was occuring.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 7 20:01:45 2002

This is an archived mail posted to the Subversion Dev mailing list.