Re: svn commit: rev 1649 - trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

On Sat, Apr 06, 2002 at 05:01:32PM -0600, cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: 2002-04-06 23:01 GMT
> New Revision: 1649
>
> Modified:
> trunk/subversion/clients/cmdline/util.c
> trunk/subversion/libsvn_client/commit.c
> Log:
> Fix error handling when the $EDITOR is needed but unavailable. Ah
> ... now that's *much* nicer.
>
> * subversion/clients/cmdline/util.c
> (svn_cl__edit_externally): Clean up the "no external editor" error message.
> (svn_cl__get_log_message): Wrap "no external editor" errors with
> helpful hints about the -m and -F options.
>
> * subversion/libsvn_client/commit.c
> (svn_client_commit): Actually capture and propogate "no external
> editor" errors.
>
Some points about this change.

1) Unsetting $EDITOR isn't really all that feasible, since a lot of other
programs use it. Why not have an option in the config file for it?

2) I thought we weren't going to have svn try to force log messages, since its
not feasible anyways.

3) What BenC said about people expecting an editor to pop up even without
$EDITOR set.

4) Will this fix other operations that commit, svn cp, svn mkdir, etc?

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~