[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1508 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/bindings/ruby

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-03-14 21:04:48 CET

On Thu, Mar 14, 2002 at 09:53:57AM -0600, Karl Fogel wrote:
>...
> Yah, iirc we discussed this with Greg Stein when he was in town the
> other week, too. I think doing the Right Thing is worth it here, even
> though it takes a little more time. Let's get the svn_wc_entry_t mess
> cleaned up once and for all.

Agreed. That checkin was just a teeny step to help isolate what entries.c is
doing (and how it does its work).

> Question, folks: do we want an open structure with settable members,
> and a pair of reader/writer conversion functions? Or do we want an
> opaque structure with accessor methods?

An open *read only* structure. If you want to change it, then you use
functions to do so (which can then perform the appropriate merging).

> I lean toward the open structure, for simplicity, and don't see any
> advantage to accessors here. But when we were talking with Greg, we
> all seemed to think accessors were the way to go. Were we just hand
> waving, or was there a real reason?

I meant accessors in terms of modification. We definitely want a visible
structure for reading the data.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 14 21:02:21 2002

This is an archived mail posted to the Subversion Dev mailing list.