Re: svn commit: rev 1508 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/bindings/ruby

On Thu, Mar 14, 2002 at 09:40:15AM -0600, cmpilato@collab.net wrote:
> Ben Collins-Sussman <sussman@collab.net> writes:
> > cmpilato@collab.net writes:
> > > 2. (much more involved solution) Promote all entry members to
> > > first-class citizens, and in doing so, might I recommend losing
> > > the "attributes" hash that lives in the entry, too? That hash is

[ yes on losing the hash, publicizing that outside of the disk read/write
  was low Fu... ]

>...
> Heh, I wonder if this means that the modify_entry function will now
> look something like:
>
> modify_entry (svn_wc_entry_t *entry, /* the entry to modify */
> svn_wc_entry_t *new_vals, /* a nice place to hold new values */
> apr_uint16_t modify_flags, /* bit-mask of which values to mod */
> apr_pool_t *pool) /* our favoritest structure in svn */

For this suggested API, 'new_vals' ought to be const.

Personally, I like this API *much* better than the existing modify_entry
API. That said, I gotta simply lodge a protest against the whole concept of
modify_entry() :-)

[ meaning: the above form is an improvement for the short/mid-term, but
  longer term, I think we could do better ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org