[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1471 - trunk/subversion/mod_dav_svn

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2002-03-09 00:35:02 CET

On Fri, Mar 08, 2002 at 04:31:10PM -0600, Ben Sussman wrote:
> Fix proptest.py test 3 failing over ra_dav.
>
> This is really weird; why have we never seen this problem before?
> We've been receiving unmangled props from svn.collab.net for a long
> time, and we always build httpd with --enable-maintainer-mode on the
> server.

Maybe this was a regression with the upgrade to neon 0.19, which stopped
stripping leading whitespace (e.g. CR) characters from cdata? Does that
explain it?

> * deadprops.c (dav_svn_db_output_value): the extra DEBUG_CR was being
> sucked up as the cdata value of the property, so then ra_dav was
> pushing bogus property values into the wc.
>
> Modified: trunk/subversion/mod_dav_svn/deadprops.c
> ==============================================================================
> --- OLD/trunk/subversion/mod_dav_svn/deadprops.c Fri Mar 8 16:30:59 2002
> +++ NEW/trunk/subversion/mod_dav_svn/deadprops.c Fri Mar 8 16:30:59 2002
> @@ -241,7 +241,7 @@
> {
> /* add <prefix:name>value</prefix:name> */
>
> - s = apr_psprintf(db->p, "<%s%s>" DEBUG_CR, prefix, name->name);
> + s = apr_psprintf(db->p, "<%s%s>", prefix, name->name);
> apr_text_append(db->p, phdr, s);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 9 00:36:19 2002

This is an archived mail posted to the Subversion Dev mailing list.