Re: Updated [patch] new part 1 for log command

>
> > + base = ((svn_stringbuf_t **) (targets->elts))[0];
> > + svn_path_split (base, &basename, &file, pool);
>
> This split is only used by the nelts == 1 case (to get the file). It should
> move for clarity. Also, note that the nelts==1 case doesn't need basename,
> so you can pass NULL for that parameter (not &foo where foo is NULL).

No, file is only used in the == 1 case. basename is used in both.

> > + URL = svn_path_uri_encode(&path_str, pool);
>
> This is only needed for the nelts > 1 case, so it should be moved.

Again, it is needed for both. path_str is changed for the == 1 case, but
both cases need it (else where does the URL get set? :)

>
> The indentiation here looks weird. Tab characters? Please avoid the use of
> hard tabs in the code. In emacs, we ues (setq indent-tabs-mode nil)
>

I can setup vim to do this just fine :)

I'll clarify the above block with some comments on when and where each
variable gets used, and in which cases.

-- 
 .----------=======-=-======-=========-----------=====------------=-=-----.
/       Ben Collins    --    Debian GNU/Linux    --    WatchGuard.com      \
`          bcollins@debian.org   --   Ben.Collins@watchguard.com           '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org