[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: to use braces or not? (was: Re: [PATCH]: A newer, better, svndiff)

From: Alex Holst <a_at_area51.dk>
Date: 2002-02-20 09:24:54 CET

Quoting Daniel Stenberg (daniel@haxx.se):
> On Wed, 20 Feb 2002, Alex Holst wrote:
> > Speaking from a code review point of view, the more the consistency the
> > better -- in all areas. It would help if these personal styles were
> > overruled by a project standard. Lots of little details like these can help
> > speed up an audit.
> Reviews are not everything. I'd personally hate that restrictive coding style
> when actually writing code.
> People who can't handle braces or not when reviewing should probably not be
> reviewing at all. IMHO.

There's a difference between casually reviewing code and not so casually
reviewing code. Code style does indeed make a difference. If the code is
completely consistent it means you can verify the correctness of a
screenful of code in 4-5 seconds as opposed to 15 or 20 seconds.

It becomes a matter of habit: when there's only one way to handle files,
varibles, user input, etc., incorrect usage stands out. With 526422
lines of text (some being documentation) in the latest svn tarball,
(that's excluding Apache 2) I think any small change that makes a
difference helps.

I prefer the dark of the night, after midnight and before four-thirty,
when it's more bare, more hollow.                  http://a.area51.dk/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.