[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: to use braces or not? (was: Re: [PATCH]: A newer, better, svndiff)

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-02-21 05:58:26 CET

Daniel Stenberg <daniel@haxx.se> writes:
> On Wed, 20 Feb 2002, Alex Holst wrote:
> > Speaking from a code review point of view, the more the consistency the
> > better -- in all areas. It would help if these personal styles were
> > overruled by a project standard. Lots of little details like these can help
> > speed up an audit.
>
> Reviews are not everything. I'd personally hate that restrictive coding style
> when actually writing code.
>
> People who can't handle braces or not when reviewing should probably not be
> reviewing at all. IMHO.

+1

And I'd also point out that Greg Stein (the original advocate of
flexible coding standards) does more code review here than the next
three people combined. So if it's not causing *him* a problem, than I
think the assertion that flexibility slows down audits must be viewed
with at least some suspicion. :-)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.