Re: [patch] add some formatting to webdav browsing

Ben Collins <bcollins@debian.org> writes:

> This patch actually adds some newlines to the html output. I was trying
> to test some other changes, but it was pretty difficult to see when the
> html returned was a single line :)
>
> Anyway, this also adds a ".." link to go to the parent directory.

I love the intent of this patch. I, too, was a bit disappointed by
the lack of newlines in the HTML output here. I do have to make a
small complaint about your log message not mentioning and symbol names
(see "Writing Log Entries" in the HACKING file).

> + if (resource->info->repos_path && resource->info->repos_path[1] != '\0')
> + ap_fprintf(output, bb, " <li><a href=\"../\">..</a></li>\n");

Also, I have a question about this portion of the code. I'm not
currently building in shared object mode (I switch every couple of
weeks depending on what I'm working on), so I haven't actually tried
this code out. But I was wondering if the result someone sees in
their browser when traversing down a few directories, then up the
chain of '..' links, is something like:

   http://svn.collab.net/repos/svn/trunk

or something like:

   http://svn.collab.net/repos/svn/trunk/subversion/test/libsvn_fs/../../..

I would prefer the former, and imagine this is quite possible using
svn_path_remove_last_component(resource->info->repos_path) to get the
parent's path (and I suppose that would get appended to some base
repository URL certainly stashed somewhere).

Of course, your code may already give me my desired results, in which
case you can simply reply with, "Don't knock it 'til you've tried it."
:-)

Thanks, Ben!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:08 2006