Re: feature negotiation?

On Tue, Feb 12, 2002 at 04:42:18PM -0600, Ben Collins-Sussman wrote:
>
> I was talking with someone on #svn, and heard a story about how he had
> used a very old (0.6) svn client to try and update his working copy.
> The server then sent binary diffs (a relatively new-ish feature) that
> ended up trashing his working copy.
>
> My question is: do we need client/server feature negotiation?

We have it already. The server only sends svndiff data when the client sends
a specific header. In other words, the client said "here is what I have, if
you can give me a diff against that, then great. otherwise, just send me a
fulltext of X." On the other side, the server sees the header and can choose
to send a diff, or it can send the fulltext. If the server doesn't know
about the headet, then it will just be sending the fulltext because it
doesn't know what to diff against.

So the fact that the person's WC got garbled is a bug somewhere. Not a lack
of feature negotiation.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org