[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1228 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/libsvn_ra_dav

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-02-13 00:30:30 CET

whew... big one to review. took me a while to get to...

On Fri, Feb 08, 2002 at 08:22:13PM -0600, sussman@tigris.org wrote:
> +++ NEW/trunk/subversion/libsvn_wc/get_editor.c Fri Feb 8 20:22:13 2002
> +svn_wc_install_file (const char *file_path,
> + svn_revnum_t new_revision,
> + const char *new_text_path,
> + const apr_array_header_t *props,
> + svn_boolean_t is_full_proplist,
> + apr_pool_t *pool)
> + if (is_full_proplist)
> + {
> + /* If the caller passed a definitive list that represents all
> + of the file's properties, we need to compare it to the
> + current 'pristine' list and deduce the differences. */

Why? If a full proplist is provided, then just install the darned thing. The
current code generates diffs between the full set and the current set, and
then later applies those diffs to generate the full set.

Seems a bit complex :-)

> /* foreach entry prop... */
> - for (i = 0; i < fb->entrypropchanges->nelts; i++)
> + for (i = 0; i < entry_props->nelts; i++)
> {
> const svn_prop_t *prop;
> svn_stringbuf_t *propname;
> svn_stringbuf_t *propval;
> + enum svn_prop_kind kind;
> + int prefix_len;

The "kind" variable is unued.

Other than those two items... wow. Excellent commit. I'm really psyched to
see all that stuff disappear from the file_baton!!

Note that we also have some issues with RA->get_file() returning a hash that
points to some stringbuf_t, some string_t items. Obviously, it is working
fine because we aren't trying to change the prop values, and because the
structures happen to be mildly compatible.

We can leave that for now, and clean it up with the other prop cleanup.

(and part of that is to convert all prop hashes to svn_string_t values)


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:07 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.