Re: [PATCH] Re: Goto label warning with gcc -Wall

On Mon, Feb 11, 2002 at 09:45:26PM -0600, Karl Fogel wrote:
> Blair Zajac <blair@orcaware.com> writes:
> > Attached is a patch to fix this warning.
>
> This patch looks good to me (at first I thought it was leaving the
> function without a return value, but then I looked at the code). I'll
> defer to Greg Stein to apply, as he knows best what that code is
> doing.

Yup, looks good, but missing a log message. I've gone ahead and applied it
with a log message (please send one in the future with any patch).

The unknown_URI label was multiply-used in the past, but after some
simplifications it became just that one reference. Combining them was the
right approach.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org