Blair Zajac <blair@orcaware.com> writes:
> Attached is a patch to fix this warning.
This patch looks good to me (at first I thought it was leaving the
function without a return value, but then I looked at the code). I'll
defer to Greg Stein to apply, as he knows best what that code is
doing.
-K
> Index: ./subversion/mod_dav_svn/repos.c
> ===================================================================
> --- ./subversion/mod_dav_svn/repos.c
> +++ ./subversion/mod_dav_svn/repos.c Mon Feb 11 18:44:10 2002
> @@ -985,8 +985,10 @@
> #ifdef SVN_DEBUG
> if (comb->res.type == DAV_RESOURCE_TYPE_UNKNOWN)
> {
> + /* Unknown URI. Return NULL to indicate "no resource" */
> DBG0("DESIGN FAILURE: should not be UNKNOWN at this point");
> - goto unknown_URI;
> + *resource = NULL;
> + return NULL;
> }
> #endif
>
> @@ -1026,11 +1028,6 @@
> "special resource area, but does not exist. This is "
> "generally caused by a problem in the client "
> "software.");
> -
> - unknown_URI:
> - /* Unknown URI. Return NULL to indicate "no resource" */
> - *resource = NULL;
> - return NULL;
> }
>
> static dav_error * dav_svn_get_parent_resource(const dav_resource *resource,
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006