Found that apr_destroy_pool bug

At libsvn_subr/io.c 1128, if you comment out the lines

// apr_pool_cleanup_register (cntxt, (void*) *fd_p,
// close_file_descriptor, NULL);

The apr_destroy_pool crash goes away. I'm not entirely sure yet, but my
guess is that the file descriptor is getting closed somewhere else in
subversions code well before apr_destroy_pool() gets called and that
this cleanup is redundant and causes windows to try and close the file
descriptor twice. I've already verified that the file descriptor thats
getting _close() 'ed in the apr_destroy_pool() callback
close_file_descriptor() is closed before the call to _close()

One option is not cleanup the descriptor, if its getting cleaned up
elsewhere correctly, the other option I see is to check whether the file
descriptor is open before attempting to close it (which causes a kernel
crash on some versions of windows).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006