Re: Peer-reviewed commits

Sean Russell <ser@germane-software.com> writes:
> I know that this functionality is not within the current scope of
> Subversion, but if I were to start writing a system based on
> Subversion to do this, would I be wasting my time -- IE, are there
> already plans for something like this, is there a better way to do it, etc?

Oh, it would most certainly *not* be a waste of time -- it would be a
huge win for Subversion to have a tool(s) like this!

You say that this functionality is "not within the current scope of
Subversion", but actually I think it is...

This functionality shouldn't be built into Subversion itself (except
for a couple of minor tweaks to, say, leave a txn around for review).
Instead, it should be implemented by tools that wrap Subversion in
fairly straightforward ways.

To summarize the two strategies described by you and cmpilato:

   - The commit txn can just hang around; a reviewer is notified that
     it's there, and the reviewer can approve, rebut, or modify the
     change.

   - People commit to branches, the reviewer is notified, reviews the
     diff on the branch, and rebuts it or ports it over to the trunk
     (or whatever line of development is desired).

All of this can be implemented on top of Subversion right now, as CGI
scripts (they can even use the repository to track change state). You
don't even need to wait for "svn merge" to be finished, although that
may make things a bit easier in a few cases.

Go for it! This would be such an incredibly winning thing, I am at a
loss for words, and as you know, that doesn't happen very often. :-)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:05 2006