Re: [PATCH]: Automatic log file removal

On Mon, Feb 04, 2002 at 03:12:02PM -0500, Daniel Berlin wrote:
> On Mon, 4 Feb 2002, Greg Stein wrote:
>...
> > 3) Apache opens/closes the FS on each request;
> Really?

No. I'm lying. ;-)

Yes, really.

>...
> > this thread would barely get
> > started before it died; even worse, it would introduce context switching
> > on every request, when we opened the repos
>
> This could be fixed easily, by having the log file archiver open the db
> itself anyway when the module starts.
> etc.

Yup. That's why I prefaced this part with "needs more work" :-) There is an
Apache hook called "child_init", IIRC, which would do this. However, we're
really want it as a post-config hook to start the reaper in just one
process.

I like Mike's suggestion of just putting this into the post-commit hook.

But even that may not be sufficient. When somebody does an "svn update", we
construct an SVN transaction. I bet that transaction gets tossed into the
log files.

[ an easy test is to just issue 1000 updates against a server and see if the
  logs grow ]

>... [ excellent explanation ] ...

> Keeping every log file by default is solving a problem that is already
> solved in multiple ways.

Good points all. Okay.. you're right: we should toss them by default, and
allow an administrator to keep them with a bit of work.

>...
> keeping them for some time interval. But requiring a separate script just
> adds another step most people have to take to set up subversion.

Right. I would hope that we can refine our system to make it easy to set up.
We're still pre-alpha right now, after all :-)

I don't believe our server will ever be quite as easy as CVS, though. Some
of our capabilities come at a cost (threaded, high capacity server; robust
database; etc). But we can endeavor to make it as simple as possible.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org