Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get

On Sat, Feb 02, 2002 at 08:34:44PM +0000, Philip Martin wrote:
> +#ifdef APR_HAS_THREADS
> + status = apr_thread_mutex_lock(umask_mutex);
> + if (!APR_STATUS_IS_SUCCESS(status))
> + return status;
> +#endif

Shouldn't this be
#if APR_HAS_THREADS

i.e. isn't it always defined to either 0 or 1.

And the rest below...

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~