Re: svn commit: rev 1124 - trunk/subversion/libsvn_wc

Greg Stein <gstein@lyra.org> writes:
> Really?! Crap. I asked at one point and somebody blamed APR.
>
> Well, feh. We definitely must change it then.
>
> ISO 8601, baby!

+1 -- I'm all for it.

But I don't think this should be done by changing either of these

   const char *svn_time_to_nts (apr_time_t when, apr_pool_t *pool);
   apr_time_t svn_time_from_nts (const char *timestr);

Right now they implement a nice read-write invariance on apr_time_t,
and it seems foolish to just throw that away. Converting apr_time_t
to ISO 8601 and back can lose information.

Probably those functions belong in APR

   const char *apr_time_to_nts (apr_time_t when, apr_pool_t *pool);
   apr_time_t apr_time_from_nts (const char *timestr);

since Subversion itself doesn't really need that r-w invariance. Then
Subversion can do whatever it needs to do to use ISO 8601 dates
internally, converting to and from apr_time_t with abandon.

I'll put this mail into

   http://subversion.tigris.org/issues/show_bug.cgi?id=614

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:01 2006