I've created
http://subversion.tigris.org/issues/show_bug.cgi?id=619
for this. Haven't set the "assigned to" field in the issue; Philip
(or anyone), want to grab it?
-K
Greg Stein <gstein@lyra.org> writes:
> On Thu, Jan 31, 2002 at 07:29:10PM +0000, Philip Martin wrote:
> > Justin Erenkrantz <jerenkrantz@ebuilt.com> writes:
> >...
> > > Code style for one. =) But, I see no overall reason why it
> > > couldn't go into APR.
>
> I recall even talking about moving the copy() function in there, and could
> have sworn that I did already. Sigh...
>
> >...
> > apr_file_copy/apr_file_append have no platform dependent code, they
> > are implemented in terms of other APR functions. Given this, are they
> > still candidates to be added to APR?
>
> Absolutely. Once you move apr_file_copy() into APR, then it *can* use
> platform dependent code. On Win32, there is a CopyFile() function that can
> be used. On platforms with sendfile(), that would be used to make the copy.
>
> > If so how do we avoid duplicating
> > the code over the platforms, is it acceptable to implement them in
> > file_io/unix/copy.c say and then have the other platforms #include the
> > unix version?
>
> Yup, that is normally how it is done for most of the platforms. Windows just
> puts the unix pathname into the .dsp file (and Netware does similarly for
> its project files).
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:01 2006