Re: apr_copy_file and apr_transfer_file_contents

Justin Erenkrantz <jerenkrantz@ebuilt.com> writes:

> > > What is the status of these "apr in subversion" functions?
> >
> > I think these functions were meant to go into APR eventually, I'm not
> > sure why they haven't yet. If there's currently a bug, obviously that
> > would be one reason not to put them in APR yet. :-)
>
> Code style for one. =) But, I see no overall reason why it
> couldn't go into APR.
>
> It'd also need to be renamed to apr_file_copy() not apr_copy_file()
> to follow APR's naming conventions. Perhaps someone can clean it
> up and post a suitable patch to dev@apr? I have no idea when I'd
> be able to get to it... -- justin

apr_file_copy/apr_file_append have no platform dependent code, they
are implemented in terms of other APR functions. Given this, are they
still candidates to be added to APR? If so how do we avoid duplicating
the code over the platforms, is it acceptable to implement them in
file_io/unix/copy.c say and then have the other platforms #include the
unix version?

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org