[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1109 - trunk/subversion/svnadmin trunk/subversion/libsvn_fs trunk/subversion/libsvn_wc trunk/subversion/svnlook trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_fs trunk/subversion/libsvn_delta trunk/subversion/libsvn_ra_dav

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-01-30 01:31:19 CET

On Tue, Jan 29, 2002 at 05:05:06PM -0600, kfogel@tigris.org wrote:
>...
> Log:
> Make all string --> svn_revnum_t conversions use casted atol().
>
> (It had been very inconsistent: sometimes we used atoi, sometimes
> atol, sometimes with a cast, sometimes without. Noticed this while
> working on unrelated changes to svn diff.)

Probably would have been even better to have a function in libsvn_subr do
this so that everything is isolated into one place. If we ever want to
change something aboue marshalling svn_revnum_t back/forth to strings...

Obviously, not a "must have" but if a function was added, then we could
switch the code whenever we were near it...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:01 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.