Re: [PATCH] issue #532 read-only admin area

Philip Martin <philip@codematters.co.uk> writes:
> Should we remove all occurrences of this construct? Trying
>
> $ for i in ../svn/subversion/libsvn_*/*c;do gawk '/if *\(err\)/{getline;if(/return *err/)print FILENAME":"NR}' $i;done
>
> gives me 92 places that might be changed.

Watch out for occurrences where we really do want to check the error
by hand, because the return is delayed or some other special handling
is going on.

But, yes, all occurrences of

    err = blah();
    if (err)
      return err;

can be changed to

   SVN_ERR (blah ());

when `err' is an svn_error_t *.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006