Re: [PATCH] issue #532 read-only admin area

Philip Martin <philip@codematters.co.uk> writes:

> > Another one for SVN_ERR()
>
> Should we remove all occurrences of this construct? Trying
>
> $ for i in ../svn/subversion/libsvn_*/*c;do gawk '/if *\(err\)/{getline;if(/return *err/)print FILENAME":"NR}' $i;done
>
> gives me 92 places that might be changed.

I wouldn't systematically just replace them all. Our public API would
be a heckuva lot cleaner if instead of always blindly passing back
every error code that comes out way, we would, at key places just
inside the public API, wrap those errors with one of a few general
error types.

I long for the day when our public API docstring can read:

   This function does ...

   Return values:
      SVN_NO_ERROR
      SVN_ERR_WC_ENTRY_NOT_FOUND
      SVN_ERR_...

Ya know? I've grown to love that about the Windows SDK ... predictable
set of possible return values.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006