Re: svn commit: rev 1080 - trunk/subversion/include trunk/subversion/libsvn_fs trunk/subversion/mod_dav_svn trunk/subversion/tests/libsvn_delta trunk/subversion/libsvn_delta trunk/subversion/libsvn_ra_dav

On Sun, 2002-01-27 at 19:32, gstein@tigris.org wrote:
> Turn svn_txdelta_window_t into a readonly structure, rather than a
> dual purpose build/use structure.

I don't particularly agree with this change, on two grounds:

1. The motivation for it isn't very clearly spelled out. Is there a
real problem with having a dual-purpose build/use structure in this
case?

2. Assuming there is a good motivation for the change, I don't see any
reason to use a baton (which has no type safety) for building
instructions. Why not define a real, fixed type for the instruction
buffer?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006