[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1062 - trunk/subversion/clients/cmdline

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-01-25 20:21:54 CET

On Fri, Jan 25, 2002 at 11:43:45AM -0600, kfogel@tigris.org wrote:
>...
> + /* we didn't manage to write the complete file, we can't fulfill
> + what we're set out to do, get out */
> + /* ### FIXME: The documentation for apr_file_full_write()
> + doesn't explicitly promise that if size != written, then
> + there *must* be an error returned, so below we handle the two
> + cases separately. But a glance at apr_file_full_write's
> + implementation, on Unix at least, shows that it could
> + document that promise. Maybe we should fix the doc in APR,
> + and just check rc below? */

The intent is that it will write out all of the bytes requested *or* return
an error. If you get an error, then you can look at the bytes_written to see
how far it got before issuing the error.

You have commit privs on APR, please feel free to update the doc in a way
that seems more clear to you.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.