Re: svn commit: rev 1062 - trunk/subversion/clients/cmdline

Greg Stein <gstein@lyra.org> writes:
> You asked me once about APR_STATUS_IS_SUCCESS ...
>
> IMO, the macro is bogus. The other apr_errno macros are used to check the
> status against multiple errors, based on the platform you're on. (e.g. a
> file not found might have several possibilities on Windows)
>
> But there is only /one/ "success" code. So testing directly against
> APR_SUCCESS is quite legal:

Um... no?

Looking in apr.h, I see that APR_STATUS_IS_SUCCESS() is *not* always
defined as a simple test against zero.

But I'd like to agree with you, so if there's an argument why we can
ignore the inconvenient fact above, I'd love to hear it...

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006