Daniel, the plan looks good. +1 on getting this basic functionality
working first, then discussing fancier stuff. :-)
Daniel Stenberg <daniel@haxx.se> writes:
> * If the commit returns not successful, a new temporary file is created and
> the previously entered commit message is store in the file. A message is
> presented to stdout about this. People who write long commit messages
> before failed commits will appreciate this! ;-)
Heh, nice idea.
> (Regarding temporary files: they're currently stored in the
> "$root/.svn/tmp/" dir, $root being the root dir of the targets that are
> about to get committed. svn_wc_create_tmp_file() didn't fit me since it
> opens the temp file DELONCLOSE, which none of the above two temp files
> should do. Could we add a boolean or flags argument to that function? I
> could only fine one other user of it.)
Yeah, changing the interface sounds fine.
> Currently the "$EDITOR code" does not deal with error codes properly (or
> fully), mostly because of the situation I discussed in a previous mail that
> the client's error codes are polluting the library error code include file. I
> would like permission to commit this first, and then attack the cmdline
> client's error code situation viciously! :-)
Completely agree.
> I have tested the code, but it needs more eyes and more testing.
Post. :-)
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:59 2006