[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #604 report

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-01-24 14:56:10 CET

On Thu, Jan 24, 2002 at 02:07:30PM +0100, Daniel Stenberg wrote:
> A few inlined questions follow.
>
> I've implemented a couple of things that can be considered issue #604 stuff
> or closely related. My hope is that we can concentrate on this CVS-mimic
> behavior first, and then possibly start adding more fancy features when this
> is done and committed.
>
> It currenly does this:
>
> * If no commit message is given, it fires up an editor for you. The editor
> is picked from environment variables, and they're tried in this order:
> SVN_EDITOR, EDITOR, VISUAL and if none of them are set, notepad.exe
> is used on win32 machines and /bin/vi on all other.

something just occured to me concerning our use of environmental
variables and how that could interact with Win32. in perforce, you
set several env variables (P4EDITOR, P4SERVER, an a few others if i
recall correctly), and the client uses them as you would expect. this
can be done on windows, just as it can on unix, but in addition, you
have the option of setting these options in the registry instead of as
env variables. this is, obviously, much more intuitive for a Win32
user, as many of them don't even know what an environment variable is.

the cool thing is, we can get this almost for free. the config file
parsing code that just went in is capable of setting things in the
registry on windows, so if we just make a policy of allowing any evn
variable we use to be overriden by a config option, we would get this
behavior. then all we need to do is provide a command line command
for getting and setting options in the config file, and windows users
are all set. they just do a 'svn confset EDITOR notepad.exe', and the
correct registry setting is set up for them. on unix, it could be
used the same way, except it would simply read in the config file, add
a new option to it, and the write it back out. we would also need
'svn confget EDITOR', or something like that, and then people would
never have to actually edit their config files (or registry keys), by
hand.

this wouldn't need to be limited to EDITOR, we could also use it for
things like the proxy setting that we've wanted to get from env
variables, although we've been leery of doing so because it isn't
cross platform (although i'm not sure how windows stores proxy
settings, i imagine it is in the registry somewhere, so it would be
nice if we could provide access to windows default setting, which
could be overriden by our setting, but this is something that needs to
be hashed out by people who know more about windows than i do...

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:59 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.