On Wed, Jan 23, 2002 at 06:28:29PM +0300, Vladimir Prus wrote:
> cmpilato@collab.net wrote:
>
> > Well, I was about to freak out reading this portion of the patch until
> > I saw you comment here. Whew! So, you've hit on something that has
> > been bothering me for some time about our Python tests -- we don't
> > detect segfaults. How hard would it be to adjust svntest.main.run_svn()
> > so that it *could* return an error if a segfault occured (perhaps a -1
> > instead of a 1, something) ? My feeling is that the Right Way to do
> > this is to first fix the broken run_svn() function, then use it. That
> > way you essentially get credit for fixing the entire Python test suite,
> > and we don't have to revisit this again. :-)
>
> I don't think we can do it in a completely portable fashion. AFAIK,
> os.popen2/os.popen3 give no way to find program's return status, and the
> Popen3 class is not available on windows. Would it be ok to use Popen3 on
> Unix, and retain the current behaviour on win?
i looked at this a little while back when writing some test cases, and
came to the same conclusion regarding os.popen2 and os.popen3. didn't
find the Popen3 class though, so that might be a reasonable solution.
i wonder (not having looked at it yet), if it would be possible to
provide the same functionality on windows and submit it back to the
python people. any win32 people out there willing to take a look?
-garrett
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:58 2006