Vladimir Prus <ghost@cs.msu.su> writes:
> cmpilato@collab.net wrote:
>
> > Well, I was about to freak out reading this portion of the patch until
> > I saw you comment here. Whew! So, you've hit on something that has
> > been bothering me for some time about our Python tests -- we don't
> > detect segfaults. How hard would it be to adjust svntest.main.run_svn()
> > so that it *could* return an error if a segfault occured (perhaps a -1
> > instead of a 1, something) ? My feeling is that the Right Way to do
> > this is to first fix the broken run_svn() function, then use it. That
> > way you essentially get credit for fixing the entire Python test suite,
> > and we don't have to revisit this again. :-)
>
> I don't think we can do it in a completely portable fashion. AFAIK,
> os.popen2/os.popen3 give no way to find program's return status, and the
> Popen3 class is not available on windows. Would it be ok to use Popen3 on
> Unix, and retain the current behaviour on win?
Hrm...bother. For some reason I seem to recall that our Python tests
won't run under Windows right now anyway, but certainly we should do
all we can to enforce that brokenness.
And here's a quote from the Python online docs to support your claim:
The only way to control the input and output streams and also
retrieve the return codes is to use the Popen3 and Popen4 classes
from the popen2 module; there are only available on Unix.
And let me guess... os.system will only give you the return value,
right? (reading, reading, reading) Yep. Oh, and the return value for
that is system-dependent. How...portable. Thanks, Python.
Well, I dunno what to do, then. We can't just look for 'core' files
because your environment variables can toggle the creation (and name,
right?) of those core files, if memory serves correctly.
Any suggestions, list-folk?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:58 2006