Re: raises hand for bite-sized issue #604

On Tue, Jan 22, 2002 at 02:35:59PM -0600, Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
>...
> > I've added my comments on the problem to the issue. In a nutshell: EDITOR is
> > non-portable, no matter how much APR you throw at it. People should accept
> > that some #ifdef WIN32 will appear in the code :-)
>
> Which code, APR or Subversion?
>
> If you mean the latter, I don't see how EDITOR being non-portable
> implies this.

The EDITOR *concept* is very non-portable. At an application level. Thus,
APR is not going to be able to hide (from Subversion) that WIN32 just can't
do it. Thus, SVN is going to have #ifdef WIN32 in it for the EDITOR
functionality.

If you believe contrary, then outline what the EDITOR concept means on
Windows. "popping up an editor" just isn't normal Win32 behavior.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org