[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: raises hand for bite-sized issue #604

From: Mark Benedetto King <bking_at_answerfriend.com>
Date: 2002-01-22 21:34:22 CET

On Tue, Jan 22, 2002 at 12:31:57PM -0800, Greg Stein wrote:
> On Tue, Jan 22, 2002 at 02:31:50PM -0600, Karl Fogel wrote:
> >...
> > And there are many other ways to solve this, in addition the one Mike
> > pointed out.

That solution (generating a patch, reverting, doing the "partial commit",
and then applying the patch) doesn't solve the problem when you're
trying to commit N/2 rather than N-1 of your changes.

> >
> > -1 on Subversion parsing the log message. Let's please not go there.
> > In the same sense that some changes are "bug sources", this has the
> > potential to be a very fertile "unexpected behavior source", while
> > adding no functionality that can't be gotten in other ways.
> >
> > If someone wants to write their pre-commit hook scripts to parse log
> > messages, that's different. But Subversion itself shouldn't ship with
> > that functionality built in.
>
> If the client is going to insert a bunch of lines (e.g. with the files that
> are being changed), then the client better remove the lines that it
> inserted.
>
> The last thing that we want is to ship a system that inserts a bunch of
> stuff into the log message and then ends up dumping all of that into the
> logs on the server.
>

Right, it's definitely up to the client, not the server. pre-commit
hooks are therefore not the way to go.

Since it seems like a touchy issue, maybe, instead, we could have
a command line option that specifies a file that contains a list of files
to commit. This gives the functionality I want, without overloading
the $EDITOR functionality. I'd be happy to implement this (trivial)
option. Comments?

> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:58 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.