Re: svn commit: rev 834 - trunk/subversion/libsvn_wc

"Sander Striker" <striker@apache.org> writes:

> > No, but I think you are close. I am *not* registering child_cleanup,
> > it is the child's copy of plain_cleanup that is running. However it
> > might be possible to add a child_cleanup to remove the plain_cleanup
> > function for the child. I will investigate.
>
> You are saying the pools is cleared or destroyed in the child?
>
> Other solution is to register the cleanup after the fork (a bit yucky
> maybe)??
>
> I'll go look at the source and get back to you.

If you want to see the problem look at run_diff_cmd in
subversion/libsvn_client/repos_diff.c. If you take out the removal and
reinstating of the cleanup handlers then

   svn diff -r829:830 http://svn.collab.net:81/repos/svn/trunk/

fails with

svn_error: #21071 : <Error calling external program>
  Error calling /usr/bin/diff.

Having got the above error I have just tried adding child_cleanup
functions to remove the plain_cleanup functions and that works. It
also makes the code much neater, this is probably the best way to
ensure that temporary files get deleted.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org