Re: svn commit: rev 834 - trunk/subversion/libsvn_wc

Greg Stein <gstein@lyra.org> writes:
> The above block is effectively duplicated twice in this file. I seem to
> recall that another checkin (from Karl?) just occurred with basically the
> same code. Ah yes... in questions.c.
>
> Let's make a utility function for this.

That's what we're doing (see upcoming checkins).

> I would recommend using APR's APR_DELONCLOSE flag for these files so that we
> can make sure they go away. That would obviate the need for apr_file_remove
> and being careful with exit branches (which Philip noted).

The files are opened, closed immediately, then opened later, written
to, then closed and removed. The second close could use DELONCLOSE,
yeah!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006