Re: 'svn diff -rREV1:REV2' code organisation

Ben Collins-Sussman <sussman@collab.net> writes:

> Philip Martin <philip@codematters.co.uk> writes:
>
> > The new code also has a dependency on svn_ra.h, which libsvn_wc
> > already has, but most of the other libsvn_* don't.
>
> libsvn_wc should *not* depend on RA at all. If you see such a
> dependency already, we should fix it.

>From svn_wc.h:

#include "svn_ra.h" /* for svn_ra_reporter_t type */
.
.
.
svn_error_t *
svn_wc_crawl_revisions (svn_stringbuf_t *path,
                        const svn_ra_reporter_t *reporter,
                        void *report_baton,
                        svn_boolean_t restore_files,
                        svn_boolean_t recurse,
                        apr_pool_t *pool);

>
> > So my question is where do you think I should put this new editor? Is
> > it OK to leave it in libsvn_wc? If it gets moved then where should
> > the svn_wc_diff_cmd_t type go so that the existing 'svn diff -rREV'
> > editor in libsvn_wc and the new editor can both use it?
>
> libsvn_client's job is to wed WC and RA together. If you need both, I
> guess it should go into libsvn_client. That way, it's also okay to
> leave svn_wc_diff_cmd_t in WC.

OK, thanks.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org