Re: 'svn diff -rREV1:REV2' code organisation

Philip Martin <philip@codematters.co.uk> writes:

> The new code also has a dependency on svn_ra.h, which libsvn_wc
> already has, but most of the other libsvn_* don't.

libsvn_wc should *not* depend on RA at all. If you see such a
dependency already, we should fix it.

> So my question is where do you think I should put this new editor? Is
> it OK to leave it in libsvn_wc? If it gets moved then where should
> the svn_wc_diff_cmd_t type go so that the existing 'svn diff -rREV'
> editor in libsvn_wc and the new editor can both use it?

libsvn_client's job is to wed WC and RA together. If you need both, I
guess it should go into libsvn_client. That way, it's also okay to
leave svn_wc_diff_cmd_t in WC.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006