Re: Trace and cancel update patches part 1

"Bill Tutt" <rassilon@lyra.org> writes:
> They're being renamed from edit_baton to trace_commit_edit_baton, or
> trace_update_edit_baton. Shorter name suggestions are greatly
> appreciated, but when they're not renamed to something unique to the
> project you're debugging, the VC watch windows get horribly confused. :(

Thanks, that clarifies.

> With a corrected log message, is this patch approved?

Yep, looks great, go ahead and commit, assuming it builds and "make
check" still passes (I didn't try that :-) ).

I was about to commit it myself before I remembered that you could do
it, so I had a log message ready. If it will save you time, feel free
to use it:

   Give baton structures unique names to ease debugging with MSVC:
   
   * clients/cmdline/trace-commit.c (trace_commit_edit_baton,
   trace_commit_dir_baton, trace_commit_file_baton): New names for
   edit_baton, dir_baton, and file_baton respectively.
   
   * clients/cmdline/trace-update.c (trace_update_edit_baton,
   trace_update_dir_baton, trace_update_file_baton): New names for
   edit_baton, dir_baton, and file_baton respectively.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:54 2006