> From: Karl Fogel [mailto:kfogel@newton.ch.collab.net]
>
> "Bill Tutt" <rassilon@lyra.org> writes:
> > Ok, here we go. I've attached the baton renaming portion of the
patch.
> >
> > * clients/cmdline/trace-commit.c:
> > * clients/cmdline/trace-update.c:
> > (edit_baton, dir_baton, file_baton): Rename baton structures to
ease
> > debugging within MSVC.
>
> Bill, do you have any way to post patches directly, rather than as
> attachments? If not, we can deal, but if it's equally convenient for
> you, then please put them in the body. It means review can be done
> right there in the mailreader, without any special unpacking. :-)
>
Outlook unfortunately doesn't allow you to turn off auto line-wrapping
nonsense, and I want the patch to make it through successfully. I can
alter attachment encoding formats, but I can't control (in Outlook) how
inline patches get munged. :( If any extension on the attachment would
help you read it easier, give a yell, and I'd be more than happy to give
it that extension.
> Btw, minor nit: what were the batons renamed *from*? (It's not clear
> from the log message whether the given names are the new names or the
> old names.)
Heh, sorry 'bout that.
They're being renamed from edit_baton to trace_commit_edit_baton, or
trace_update_edit_baton. Shorter name suggestions are greatly
appreciated, but when they're not renamed to something unique to the
project you're debugging, the VC watch windows get horribly confused. :(
With a corrected log message, is this patch approved?
Thanks,
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:54 2006