[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bitesized 576

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2001-12-13 14:44:03 CET

On Thu, Dec 13, 2001 at 08:30:07AM -0500, Garrett Rooney wrote:
> On Thu, Dec 13, 2001 at 08:09:11AM +0100, Daniel Stenberg wrote:
> > Without doing any very deep research here, I *suspect* that the code in
> > main.c must instead look similar to this:
> >
> > svn_wc_entry_t *ent=NULL;
> > err = svn_wc_entry(&ent, svn_stringbuf_create(opt_arg, pool), pool);
> > if ( (err == SVN_NO_ERROR) && ent)
> > log_under_version_control = TRUE;

Super minor nit. I don't know how others feel, but I dislike enum usage that
relies on the fact that a specific value is 0. I've been bitten too many
in the past by someone sneaking a new value in at the beginning instead of the
end of the list.

If no one else does (Daniel), I'll try to commit this patch later today.

> ...

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:52 2006

This is an archived mail posted to the Subversion Dev mailing list.