Re: svn commit: rev 572 - trunk/subversion/include trunk/subversion/libsvn_fs trunk/subversion/tests/libsvn_fs trunk/subversion/tests/libsvn_delta trunk/subversion/libsvn_delta

Karl Fogel wrote:

>Branko �ibej <brane@xbc.nu> writes:
>
>>kfogel@tigris.org wrote:
>>
>>>* subversion/tests/libsvn_delta/vdelta-test.c: Adjust likewise, and
>>>remove the command line option to set the window size, since the size
>>>is a constant now.
>>>
>>This will make some optimizations in the deltifier impossible later
>>on. For instance, if a file is within 5% of the "ideal" window size,
>>you might want to enlarge the window a bit so that the whole file fits
>>in.
>>
>>Not saying we should worry about this now, though. Just pointing out
>>possibilities.
>>
>
>Hm? I don't see how this changes anything.
>
>Any individual window can still have whatever size it wants; all this
>change does is change a global variable to a preprocess constant. If
>a window were going to have a different size from the recommended
>standard size, it wouldn't have done so by changing the old global
>variable, it would have set just its own size -- which is what it will
>still do.
>
>The size is still just a recommendation. Going from global var to
>preprocessor constant doesn't change that.
>

Uh. You're right. That stuff I was smoking must have been stronger than
I though.

-- 
Brane �ibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org