Greg Stein <gstein@lyra.org> writes:
> On Fri, Nov 16, 2001 at 01:34:06PM -0600, cmpilato@collab.net wrote:
> > Hey, Ben. Was wondering what you thought about us changing the commit
> > crawler so that mined information from the working copy first, storing
> > relavent bits in some applicable in-memory data structure and locking
> > dirs and such, then blew through that data structure to perform the
> > actual commit.
>
> Eek. That blows away all concept of streamy. -1
Yeah, eek is right. -1.
> I would suggest writing a crawler, much like Python's os.path.walk(). It
> crawls over the disk and calls a callback for each entry. You can then use
> different callbacks for status, for committing, for updating, whatever.
This sounds pretty clean to me. I like this, Greg. Thanks for the
detailed explanation.
> > Reason I ask is that I'd like to recycle alot of the logic in that
> > commit process, but for working-copy-free commits (like `svn cp' is
> > soon to do).
>
> "svn cp" for two URLs would entirely skip all this gobbledy gook. I don't
> think you'd use any common routines at all for it. Seems like it would be a
> manual sequence of calls into the commit editor, just like you posted in
> copy-planz.
Yeah, I agree. I don't understand why you want a level of abstraction
here.
> > Plus, I think it would help the commit crawler not be such a mess, to
> > seperate the local-mod search from the commit process itself.
>
> Agreed. See above. Note that the recent "copy the filesystem" walker as part
> of the wc->wc copy could be tossed in favor of the walk() function and a
> callback to copy a file/dir.
>
> (I noticed that the code to do the copy was effectively duplicating the
> other filesystem traversal stuff in the WC; no sense duplicating a basic
> function everywhere, leading to possible divergence and maintenance issues)
Ahhhh, yes! Cool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:48 2006