[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 359 - trunk/subversion/include trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/clients/cmdline trunk/subversion/libsvn_ra_dav

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-30 23:52:02 CET

On Tue, Oct 30, 2001 at 03:19:26PM -0600, kfogel@tigris.org wrote:
>...
> @@ -127,6 +144,37 @@
> #ifdef __cplusplus
> }
> #endif /* __cplusplus */
> +
>...
> +typedef svn_error_t *(*svn_log_message_receiver_t)
> + (void *baton,
> + const apr_hash_t *changed_paths,
> + svn_revnum_t revision,
> + const char *author,
> + const char *date, /* use svn_time_from_string() if need apr_time_t */
> + const char *message, /* use svn_string_t if we ever have binary... */
> + svn_boolean_t last_call);
> +
>
> #endif /* SVN_TYPES_H */

Everything defined by our headers should occur within the __cplusplus
wrappers. Even typedefs.

The only thing to leave *out* of those wrappers is when we include other
header files. We don't want to impose our "extern C" stuff on those other
headers.

Note that I believe many of our headers have ordering problems with the C++
namespace wrappers. I'm just taking this opportunity to point out the
"proper" behavior/coding :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.