[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Outstanding Patches.

From: Philip Martin <philip_martin_at_ntlworld.com>
Date: 2001-10-30 23:18:51 CET

Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:

> Sorry, I also wanted to say that if you wanted to be really cool,
> you might be able to write a new editor and just use svn_wc_crawl_local_mods.
> Otherwise svn_wc_text_modified_p might be useful.
> On Tue, Oct 30, 2001 at 09:26:08AM -0500, Kevin Pilch-Bisson wrote:
> > I would say something more along the lines of:
> >
> > svn_error_t *svn_client_diff (apr_hash_t **pfiles,
> > const svn_string_t *target,
> > svn_boolean_t recurse,
> > svn_revnum_t from_revision,
> > svn_revnum_t to_revision,
> > apr_pool_t *pool);

I am trying to understand if an svn_wc_crawl_local_mods editor for
showing diffs would work.

I can see that the information used in a commit is the same as that
required to show the difference between the working copy and the
pristine revision, so that might be made to work. However I don't see
that it would extend to the difference between arbitrary
revisions. svn_wc_crawl_local_mods seems to be pretty much hardwired
to the current working copy and the current pristine revision. This is
hardly surprising, it's in the wc library after all.

On the other hand, if my understanding of editors is correct, some
sort of editor approach might have benefits. For instance, if
arbitrary file revisons do need to be retrieved over RA then the
problem of temp file ownership/deletion goes away: the editor driver
constructs temp files, drives the editor and then cleans up. I think a
new editor driver, rather than svn_wc_crawl_local_mods, is required
though. I am not sure if the "editor" is an svn_delta_edit_fns_t
either or some other vtable.

Or have I missed the point?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.