[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 267 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client trunk/subversion/tests/libsvn_wc trunk/subversion/tests/clients/cmdline

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-19 22:19:25 CEST

On Fri, Oct 19, 2001 at 01:38:01PM -0500, sussman@tigris.org wrote:
>...
> Karl is writing a Tolstoyan essay on the theoretical problems we have
> with directories being out-of-date. In the meantime, we can make
> Hudson test #11 pass over dav by making the *client* side enforce the
> rule: "dir propchanges are only committable on up-to-date dirs".

I am presuming that the issue will remain open, with a marker to go through
and rip this stuff out?

>...
> + REVNUM_FN/REV_BATON allows this routine to query the repository for
> + the latest revision. It is used (temporarily) for checking that
> + directories are "up-to-date" when a dir-propchange is discovered.
> + We don't expect it to be here forever. :-) */
> +svn_error_t *
> +svn_wc_crawl_local_mods (svn_stringbuf_t *parent_dir,
> + apr_array_header_t *condensed_targets,
> + const svn_delta_edit_fns_t *edit_fns,
> + void *edit_baton,
> + const svn_ra_get_latest_revnum_func_t *revnum_fn,
> + void *rev_baton,
> + apr_pool_t *pool);

The typedef is already a func ptr. An additional pointer is not needed it;
it just monkeys things up. The param ought to be:

    svn_ra_get_latest_revnum_func_t revnum_fn,

There are similar declarations in other parts of this patch; I won't call
each one out.

>...
> + if (xml_dst && xml_dst->data)
> + /* committing to XML */
> + err = svn_wc_crawl_local_mods (base_dir,
> + condensed_targets,
> + editor, edit_baton,
> + NULL, NULL,
> + pool);
> + else
> + /* committing to RA layer */
> + err = svn_wc_crawl_local_mods (base_dir,
> + condensed_targets,
> + editor, edit_baton,
> + &(ra_lib->get_latest_revnum), session,
> + pool);

This would simply be ra_lib->get_latest_revnum. No need to take an address
within the structure.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006

This is an archived mail posted to the Subversion Dev mailing list.