[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 259 - trunk/subversion/libsvn_ra_dav

From: <kfogel_at_collab.net>
Date: 2001-10-19 17:49:16 CEST

Greg Stein <gstein@lyra.org> writes:
> The *problem* is that set_prop takes an svn_stringbuf_t. It has absolutely
> no need to do that since it isn't going to change the contents. That is
> exactly what the bitch in my comment said.
>
> set_prop should take "const svn_string_t *" or simply "const char *".
>
> But if we aren't going to make that change now, then my bitches should stay
> in the code so that I'll find 'em again later and fix the darned set_prop at
> some point.

This is exactly the conclusion Ben came to -- in fact, he started down
the path of making the big "change set_prop to take const
svn_string_t" road, and backed out after realizing it was going to use
up the whole day and more.

If your comment got removed from the code, it was an accident; I know
from conversation that he meant to leave it in after aborting the
larger change. There is also issue #406, so this is not going to get
forgotten about.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006

This is an archived mail posted to the Subversion Dev mailing list.